Review your own code before anyone else sees it

Here's the change I'm about to push: {{paste the diff}}. Context: {{what it's meant to do, what the codebase conventions are}}.

Review it as three different people, separately:
1. THE PEDANT — naming, dead code, inconsistent style, comments that no longer match the code, anything I clearly copy-pasted.
2. THE SCEPTIC — what happens with null, empty, zero, very large, concurrent, or repeated input. Name the specific line for each.
3. THE FUTURE MAINTAINER — what will be confusing in six months, what's implicit that should be explicit, what has no test.

Then collapse it into one list, ordered by whether I should fix it now, fix it in a follow-up, or ignore it. Be willing to put things in ignore — a review where everything is critical is useless.

Finish with the single question a reviewer is most likely to ask, and my honest answer to it.